Fixes #19218: backup file are not copied correctly when the destination directory is on another FS #3616
Conversation
|
PR updated with a new commit |
| @@ -855,28 +856,41 @@ class PolicyWriterServiceImpl( | |||
| UIO.unit | |||
| } else { | |||
| for { | |||
| mvOptions <- getMoveOptions(sortedFolder.head) | |||
There was a problem hiding this comment.
I don't think we need this now
There was a problem hiding this comment.
Hum, you're right, we need to keep the atomic move if we are on the same FS. In all case, it will give information related to performance (the warning message).
| _ <- newFolders.update( folder :: _ ) | ||
| _ <- PolicyGenerationLoggerPure.trace(s"Backuping old policies from '${baseFolder}' to '${backupFolder}' ") | ||
| _ <- backupNodeFolder(baseFolder, backupFolder) | ||
| // _ <- newFolders.update( folder :: _ ) |
There was a problem hiding this comment.
You don't add folder anymore here
There was a problem hiding this comment.
rollback in error won't be done anymore, so either no rollback or update newFolders ref
| @@ -314,6 +314,7 @@ rudder.community.port=5309 | |||
| # CAUTION: For performance and consistency, it is necessary that the rudder.dir.backup is on the same | |||
| # filesystem as /var/rudder/share/ , otherwise the policies change for nodes is non-atomic (move becomes | |||
| # copy then delete), and can result to incomplete/partial policies being distributed to nodes. | |||
| # Commant that option to disable policy backup. | |||
There was a problem hiding this comment.
Comment instead of commant
|
PR updated with a new commit |
…on directory is on another FS
|
PR rebased |
fanf
force-pushed
the
bug_19218/backup_file_are_not_copied_correctly_when_the_destination_directory_is_on_another_fs
branch
from
ab6ece7
to
e6ac344
Compare
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
fanf
deleted the
bug_19218/backup_file_are_not_copied_correctly_when_the_destination_directory_is_on_another_fs
branch
https://issues.rudder.io/issues/19218