Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected English grammar - keywords: "informations", "every" and "each" #362

Closed
wants to merge 2 commits into from
Closed

Conversation

dcabooter
Copy link
Contributor

No description provided.

@fanf
Copy link
Member

fanf commented Dec 3, 2013

Denis, thank you very much for that pull request - and sorry for the delay, I missed it somehow.
Before merging it, I would like to let you know our dev convention and process, so you understand what is going one:

  • we always try to correct things when they appear for the first time, or for the last suported Rudder version. That means that if a bug in API is discovered, we will try to propose the pull request against branch 2.7. If it's something that is broken since the first release of Rudder, we will correct it in branche 2.4 (current stable).
  • we always link a pull request to a ticket, and add the in the commit message "Fixes #XXXX" (to close the issue) or "Issue #XXXX" (to simply reference it, without closing it - that should be rarer than Fixes). That allows redmine to link to the commit in the ticket and our release manager to create accurate change logs in each release.

So, knowing that, could you:

  • open a ticket about the problem corrected by that pull request,
  • find if you corrections don't apply in earlier release than master
  • add the ticket number with the correct keyword in the commit message ?

If you have any question, please don't hesitate to ask.

@fanf
Copy link
Member

fanf commented Nov 28, 2014

This was addressed, thanks for the pr (but not relevant anymore, so I'm closing it)

@fanf fanf closed this Nov 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants