Fixes #19248: Empty /var/rudder/policy-generation-info/node-configuration-hashes.json after a policy generation that changed nothing #3637
Conversation
|
|
||
| sequential | ||
|
|
||
| "when nothing was written, we should get an empty succe" >> { |
There was a problem hiding this comment.
| "when nothing was written, we should get an empty succe" >> { | |
| "when nothing was written, we should get an empty success" >> { |
| else semaphore.withPermits(1) { | ||
| for { | ||
| current <- nonAtomicRead() | ||
| filtered = current.hashes.filterNot(h => nodeIds.contains(h.id)) |
There was a problem hiding this comment.
i'm unsure tht you need this one: you are traversing current.hashes , and n times the nodeIds
doing simply (filtered ++ hashes).toList.sortBy(_.id.value) would yield the same result
There was a problem hiding this comment.
no, filtered is a list, not a map, and hashes is not a map either, so I will have several node config hashes for the same node Id.
I would need to do current.hashes.map(h => (h.id, h)).toMap, same for hashes, so two traverse, and one more (more coslty) for the map merge.
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
…tion-hashes.json after a policy generation that changed nothing
fanf
force-pushed
the
bug_19248/empty_var_rudder_policy_generation_info_node_configuration_hashes_json_after_a_policy_generation_that_changed_nothing
branch
from
35e923c
to
1a51078
Compare
fanf
deleted the
bug_19248/empty_var_rudder_policy_generation_info_node_configuration_hashes_json_after_a_policy_generation_that_changed_nothing
branch
https://issues.rudder.io/issues/19248