Fixes #19380: make use of cache more efficient in NodeInfoService #3661
Conversation
ncharles
added
Trigger test
WIP
Fixes #19380: make use of cache more efficient in NodeInfoService
|
PR updated with a new commit |
| @@ -93,8 +93,8 @@ final case class NodeInfo( | |||
| val isSystem = node.isSystem | |||
| val isPolicyServer = node.isPolicyServer | |||
| val creationDate = node.creationDate | |||
| val nodeReportingConfiguration = node.nodeReportingConfiguration | |||
| val properties = node.properties | |||
| def nodeReportingConfiguration = node.nodeReportingConfiguration | |||
There was a problem hiding this comment.
Can you add a comment, else it will be lost the nexttime we touch that code
There was a problem hiding this comment.
it's not definitive, i'm only testing stuff
|
Do not merge, this is tests |
…nfoService Fixes #19380: make use of cache more efficient in NodeInfoService
|
PR updated with a new commit |
| @@ -375,7 +375,7 @@ trait NodeInfoServiceCached extends NodeInfoService with NamedZioLogger with Cac | |||
| TimingDebugLogger.debug(s"Getting node info entries: ${t1-t0}ms") | |||
|
|
|||
| for { | |||
| res <- ZIO.foreach(nodes) { case (id, nodeEntry) => mapOneNode(id, nodeEntry, nodeInventories, machineInventories) } | |||
| res <- ZIO.foreachPar(nodes) { case (id, nodeEntry) => mapOneNode(id, nodeEntry, nodeInventories, machineInventories) } | |||
There was a problem hiding this comment.
this is a great improvement
There was a problem hiding this comment.
this works too well and prevent policy generation to go fast :/
There was a problem hiding this comment.
you likely need to limite the parallelism with foreachParN(maxParallism)(nodes) { .... }
There was a problem hiding this comment.
yes but i don't know which value to set
…n NodeInfoService Fixes #19380: make use of cache more efficient in NodeInfoService
|
PR updated with a new commit |
…cient in NodeInfoService Fixes #19380: make use of cache more efficient in NodeInfoService
|
PR updated with a new commit |
…re efficient in NodeInfoService Fixes #19380: make use of cache more efficient in NodeInfoService
|
PR updated with a new commit |
…ache more efficient in NodeInfoService Fixes #19380: make use of cache more efficient in NodeInfoService
|
PR updated with a new commit |
…se of cache more efficient in NodeInfoService Fixes #19380: make use of cache more efficient in NodeInfoService
|
PR updated with a new commit |
|
this one is not what it says - it will need rework |
https://issues.rudder.io/issues/19380