Fixes #19567: Rudder fails to stop on boot error #3729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
commented
Jul 26, 2021
|
|
||
| // this one must be in a fork thread pool | ||
| ZioRuntime.internal.unsafeRunAsync(IOResult.effect { |
There was a problem hiding this comment.
the "async" made exception disappear and not be catched, ever. Not sure what was happening. I failed to understood why it needed to be more on an other threadpool than what is provided by IOResult.effect. It works on one cpu, with plugins with the patch, too.
ncharles
approved these changes
Jul 26, 2021
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/19567