Fixes #19625: Remove server roles in webapp and add support for remote postgres #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
amousset
reviewed
Jul 30, 2021
| def isPostgresqlLocal: Boolean | ||
|
|
||
| override def getFilteredTechnique(): Map[NodeId, List[TechniqueName]] = { | ||
| if(isPostgresqlLocal) { |
There was a problem hiding this comment.
no, we filter out technique rudder-service-postgresql when postgres is remot. If it's local, we don't filter out anything
fanf
force-pushed
the
ust_19625/remove_server_roles_in_webapp_and_add_support_for_remote_postgres
branch
from
c789391
to
6e0e5a9
Compare
|
OK, merging this PR |
ncharles
reviewed
Aug 2, 2021
| @@ -450,8 +391,8 @@ class SystemVariableServiceImpl( | |||
| val varManagedNodesCertUUID = systemVariableSpecService.get("MANAGED_NODES_CERT_UUID").toVariable(nodesWithCertificate.map(_._1.id.value)) | |||
|
|
|||
| //Reports DB (postgres) DB name and DB user | |||
| val varReportsDBname = systemVariableSpecService.get("RUDDER_REPORTS_DB_NAME").toVariable(Seq(reportsDbName)) | |||
There was a problem hiding this comment.
this was necessary for the .pgpass file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/19625