Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19729: Secret variable engine #3793

Conversation

ElaadF
Copy link
Member

@ElaadF ElaadF commented Aug 7, 2021

https://issues.rudder.io/issues/19729

⚠️ This part have been moved in https://github.com/Normation/rudder-plugins-private/pull/190

How to test it

  1. Install secret-management plugin or create /var/rudder/configuration-repository/secrets/secrets.json with this content :
{
  "formatVersion" : "1.0",
  "secrets":[
      {
          "name" : "password",
          "description":"#markdown supported",
          "value" : "password-remplaced-yeeeah"
      }
  ]
}
  1. Create a secret (or skip it if you create manually the file previously)
    image
  2. Create a node property testengine with a recognized format, like this :
{
  "login": "admin",
  "password": {
    "value": "${engine.secret[password]}"
  }
}
  1. Create a technique using this node property (I used File content with ${node.properties[testengine][password]} as lines parameter)
  2. Apply this technique through directives
  3. Check if the interpolation worked

Todo

  • Move this part in rudder-plugins-private

@ElaadF
Copy link
Member Author

ElaadF commented Aug 7, 2021

PR updated with a new commit

@ElaadF
Copy link
Member Author

ElaadF commented Aug 7, 2021

PR updated with a new commit

@ElaadF
Copy link
Member Author

ElaadF commented Aug 7, 2021

PR updated with a new commit

@ElaadF
Copy link
Member Author

ElaadF commented Aug 7, 2021

PR updated with a new commit

@ElaadF
Copy link
Member Author

ElaadF commented Aug 8, 2021

PR rebased

@ElaadF ElaadF force-pushed the ust_19729/secret_variable_engine branch from 17ff7e1 to 625850f Compare August 8, 2021 09:07
@ElaadF ElaadF force-pushed the ust_19729/secret_variable_engine branch from 625850f to a0ee1ef Compare August 8, 2021 09:18
@ElaadF
Copy link
Member Author

ElaadF commented Aug 8, 2021

Commit modified

@ElaadF ElaadF changed the base branch from master to branches/rudder/7.0 August 17, 2021 14:41
@VinceMacBuche
Copy link
Member

I do think this should be in the plugin the property engine should be added dinamically, not hardcoded within Rudder

@ElaadF
Copy link
Member Author

ElaadF commented Aug 24, 2021

This code habe been moved in https://github.com/Normation/rudder-plugins-private/pull/190

@ElaadF ElaadF closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants