-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #19753: Make rule categories editable #3808
Merged
Normation-Quality-Assistant
merged 1 commit into
Normation:master
from
RaphaelGauthier:ust_19753/make_rule_categories_editable
Aug 17, 2021
Merged
Fixes #19753: Make rule categories editable #3808
Normation-Quality-Assistant
merged 1 commit into
Normation:master
from
RaphaelGauthier:ust_19753/make_rule_categories_editable
Aug 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9a2750
to
607271a
Compare
Commit modified |
ncharles
previously requested changes
Aug 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Can you change the comment and self merge?
import ViewTabContent exposing (buildListCategories) | ||
|
||
-- | ||
-- This file contains all methods to display the details of the selected rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
-- This file contains all methods to display the details of the selected rule. | |
-- This file contains all methods to display the details of the selected category. |
607271a
to
2138f78
Compare
Commit modified |
PR rebased |
2138f78
to
1ebe2a1
Compare
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/19753