Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19753: Make rule categories editable #3808

Conversation

RaphaelGauthier
Copy link
Member

@RaphaelGauthier
Copy link
Member Author

Commit modified

Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Can you change the comment and self merge?

import ViewTabContent exposing (buildListCategories)

--
-- This file contains all methods to display the details of the selected rule.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- This file contains all methods to display the details of the selected rule.
-- This file contains all methods to display the details of the selected category.

@RaphaelGauthier
Copy link
Member Author

Commit modified

@RaphaelGauthier
Copy link
Member Author

PR rebased

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 63e9b3a into Normation:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants