Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #19776: result condition are canonifying variables #3828

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Fixes #19776: result condition are canonifying variables #3828

merged 3 commits into from
Aug 19, 2021

Conversation

VinceMacBuche
Copy link
Member

@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

amousset
amousset requested changes Aug 19, 2021
View reviewed changes
Copy link
Member

@amousset amousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to have tests for this parser, this type of regex in the editor had some recurring bugs

@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

@VinceMacBuche VinceMacBuche force-pushed the bug_19776/result_condition_are_canonifying_variables branch 2 times, most recently from 17505f6 to 2066355 Compare August 19, 2021 13:20
@Normation-Quality-Assistant
Copy link
Contributor

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant force-pushed the bug_19776/result_condition_are_canonifying_variables branch from 2066355 to b862705 Compare August 19, 2021 18:06
@Normation-Quality-Assistant Normation-Quality-Assistant merged commit b862705 into Normation:branches/rudder/7.0 Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

@RaphaelGauthier RaphaelGauthier Awaiting requested review from RaphaelGauthier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@VinceMacBuche @Normation-Quality-Assistant @amousset