Fixes #4231, Rule categories in Rule creation popup are now up to date #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| root | ||
| , category | ||
| , {(r : RuleCategory) => | ||
| root = roCategoryRepository.getRootCategory.get |
There was a problem hiding this comment.
The way "var root" is managed is no good, because in a system error (LDAP pb, or things like that), it will blow up in exception.
So, either we manage the root in a Box, or we pass it as a paramater of the rule displayer (and charge to the caller to manage the error), but we don't use Option.get without managing the case where we can't get.
|
I updated the pull request, error case are now correctly handled. I boxed the Root var in RuleDisplayer |
|
Great, thanks! |
fanf
added a commit
that referenced
this pull request
Dec 11, 2013
…up_not_updated Fixes #4231, Rule categories in Rule creation popup are now up to date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.