Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #19915: Improve rust build times #3869

Merged
merged 1 commit into from Sep 10, 2021
Merged

Fixes #19915: Improve rust build times #3869

merged 1 commit into from Sep 10, 2021

Conversation

amousset
Copy link
Member

@amousset amousset commented Sep 5, 2021

@amousset
Copy link
Member Author

amousset commented Sep 5, 2021

debug = 0 seems to make a ~10% difference locally, but could be more on slow io.

peckpeck
peckpeck reviewed Sep 6, 2021
View reviewed changes
rust.makefile Outdated
@@ -21,6 +21,9 @@ else ifneq ($(REDHATOS),)
PKG_INSTALLER := $(YUM)
endif

# https://matklad.github.io/2021/09/04/fast-rust-builds.html#ci-workflow
export CARGO_INCREMENTAL = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this slow down local developper build ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never use this makefile for local dev, but it seems to be used for rudder-lang testing so we need to do it differently indeed. I'll update the PR to pass the parameter through jenkins job directly.

@amousset
Copy link
Member Author

amousset commented Sep 9, 2021

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3869
-- Your faithful QA
Kant merge: "Morality is not the doctrine of how we may make ourselves happy, but how we may make ourselves worthy of happiness."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/44126/console)

@amousset
Copy link
Member Author

amousset commented Sep 9, 2021

OK, squash merging this PR

@amousset amousset force-pushed the bug_19915/improve_rust_build_times branch from da7db9a to 4889913 Compare September 9, 2021 18:37
@amousset
Copy link
Member Author

amousset commented Sep 9, 2021

OK, merging this PR

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3869
-- Your faithful QA
Kant merge: "Morality is not the doctrine of how we may make ourselves happy, but how we may make ourselves worthy of happiness."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/44157/console)

@amousset amousset force-pushed the bug_19915/improve_rust_build_times branch from 4889913 to 6df9b72 Compare September 10, 2021 09:35
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 6df9b72 into Normation:branches/rudder/7.0 Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckpeck peckpeck peckpeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@amousset @Normation-Quality-Assistant @peckpeck