Fixes #20359: techniques are seens as deleted even if there are there in Rudder 7.0 #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Dec 2, 2021
| @@ -512,7 +512,7 @@ object PolicyServerConfigurationObjects { | |||
| } | |||
|
|
|||
| // we need to have "common" here, even if it's not server specific, else it leads to it being deleted during migration | |||
There was a problem hiding this comment.
,could you also edit the comment
|
PR updated with a new commit |
|
this line was added to correct https://issues.rudder.io/issues/20351 so that will just revert the problm to previous bad case. |
|
let me look and find the root problem |
|
so ok, that's actually the correct correction. I added tests to check it always in PR: ncharles#11 |
fanf
approved these changes
Dec 3, 2021
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
Fixes #20359: techniques are seens as deleted even if there are there in Rudder 7.0
fanf
force-pushed
the
bug_20359/techniques_are_seens_as_deleted_even_if_there_are_there_in_rudder_7_0
branch
from
13756b3
to
27e2a83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20359: techniques are seens as deleted even if there are there in Rudder 7.0