-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #20359: techniques are seens as deleted even if there are there in Rudder 7.0 #4038
Conversation
@@ -512,7 +512,7 @@ object PolicyServerConfigurationObjects { | |||
} | |||
|
|||
// we need to have "common" here, even if it's not server specific, else it leads to it being deleted during migration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
,could you also edit the comment
PR updated with a new commit |
this line was added to correct https://issues.rudder.io/issues/20351 so that will just revert the problm to previous bad case. |
let me look and find the root problem |
so ok, that's actually the correct correction. I added tests to check it always in PR: ncharles#11 |
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
Fixes #20359: techniques are seens as deleted even if there are there in Rudder 7.0
13756b3
to
27e2a83
Compare
Fixes #20359: techniques are seens as deleted even if there are there in Rudder 7.0