Fixes #20367: first go at improving perfs for rules/tree #4039
Conversation
| @@ -755,10 +755,11 @@ class RuleApiService14 ( | |||
|
|
|||
| def getRuleApplicationStatus(rule: Rule, groupLib: FullNodeGroupCategory, directiveLib: FullActiveTechniqueCategory, nodesLib: Map[NodeId, NodeInfo], globalMode: GlobalPolicyMode): RuleApplicationStatus = { | |||
| val directives = rule.directiveIds.flatMap(directiveLib.allDirectives.get(_)).map{case (a,d)=> (a.toActiveTechnique(), d)} | |||
| val nodes = groupLib.getNodeIds(rule.targets, nodesLib).flatMap(nodesLib.get) | |||
| val nodesIds = groupLib.getNodeIds(rule.targets, nodesLib) | |||
| val nodes = nodesLib.view.filterKeys( x => nodesIds.contains(x)).values | |||
There was a problem hiding this comment.
impact of this is simply delirious. it goes from 9s to 6s with only this
There was a problem hiding this comment.
can you add a comment ? If it is significatif, it must be kept in futur refactoring
There was a problem hiding this comment.
a unit test would be more futur proof, but I have no idea how to build a relevant test for that, that won't fail randomly depending of the machine, and so being just noise
There was a problem hiding this comment.
i'm unsure also, because all other perfs tests are disabled :(
| val allTargets = rule.targets.flatMap(groupLib.allTargets.get).map(_.toTargetInfo) | ||
| val policyMode = ComputePolicyMode.ruleMode(globalMode, directives.map(_._2), nodes.map(_.policyMode)) | ||
| val applicationStatus = applicationService.isApplied(rule,groupLib,directiveLib,nodesLib) | ||
| val applicationStatus = applicationService.isApplied(rule,groupLib,directiveLib,nodesLib, Some(nodesIds)) |
There was a problem hiding this comment.
we shave again 2s with that
ncharles
added
WIP
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
VinceMacBuche
force-pushed
the
bug_20367/first_go_at_improving_perfs_for_rules_tree
branch
from
0dc0e39
to
1c1f77c
Compare
https://issues.rudder.io/issues/20367