Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #20395: css of generation status is dubious in 7.0 #4057

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Fixes #20395: css of generation status is dubious in 7.0 #4057

merged 1 commit into from
Dec 15, 2021

Conversation

RaphaelGauthier
Copy link
Member

@RaphaelGauthier
Copy link
Member Author

css-nav-notification

@VinceMacBuche
Copy link
Member

Awesome, what does the status look like when a generation is in progresse ? used to be blue

also what does the error status look like ? (i imagine like healthceck)

@VinceMacBuche
Copy link
Member

From what I read in the PR you did it !

@amousset
Copy link
Member

Awesome

@RaphaelGauthier
Copy link
Member Author

Here is the different states :
bg-status

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit feb265d into Normation:branches/rudder/7.0 Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche Awaiting requested review from VinceMacBuche

Assignees
No one assigned
Labels
Ready for merge Trigger test
Projects
None yet
Milestone
No milestone
4 participants
@RaphaelGauthier @VinceMacBuche @amousset @Normation-Quality-Assistant