Fixes #20462: Delay policy generation until rudder app is fully boot #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
requested changes
Dec 21, 2021
...rces/rudder/rudder-core/src/main/scala/com/normation/rudder/batch/AsyncDeploymentActor.scala
Outdated
Show resolved
Hide resolved
| @@ -554,6 +554,10 @@ class Boot extends Loggable { | |||
| ApplicationLogger.error(s"Error when trying to save the EventLog for application start: ${err.fullMsg}") | |||
| case Right(_) => ApplicationLogger.info("Application Rudder started") | |||
| } | |||
|
|
|||
| // release guard for promise generation awaiting end of boot | |||
| RudderConfig.policyGenerationBootGuard.succeed(()).runNow | |||
There was a problem hiding this comment.
I would never have thought to put it there, i was more thinking to put it at the end of bootcheck. It is without doubt better the way you did
|
PR rebased |
fanf
force-pushed
the
ust_20462/delay_policy_generation_until_rudder_app_is_fully_boot
branch
from
5d631d3
to
a339863
Compare
ncharles
reviewed
Dec 21, 2021
| @@ -190,6 +190,7 @@ final case class FullNodeGroupCategory( | |||
| case FullOtherTarget(t) => t match { | |||
| case AllTarget => true | |||
| case AllTargetExceptPolicyServers => !node.isPolicyServer | |||
| case AllPolicyServers => node.isPolicyServer | |||
There was a problem hiding this comment.
it removes a warning missing pattern match (and the corresponding runtime exception) for a previous pr regarding migration.
I'm adding a comment in head.
ncharles
approved these changes
Dec 21, 2021
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/20462
That PR add a promise (ie something that can be done exactly once, and that other things can wait for it to be done) that is checked for completion before actually starting policy generation.
The promise is completed at end of
Boot.bootmethod, ie once lift knows rudder is started.To be able to use the
promise.awaitin policy generation agent, I needed to transform the code into a ZIO effect.Also remove a warning for missing pattern match which would lead to a runtime exception, likely introduced in pr #4065