-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #20478: metrics are still present in wizard, and wizard doesn't end #4072
Fixes #20478: metrics are still present in wizard, and wizard doesn't end #4072
Conversation
This PR removes the metrics totally |
@@ -74,10 +74,10 @@ view model = | |||
Account s ac -> | |||
case s of | |||
Completed -> ( completeClass , completeIcon , "Your account "++ ac.username ++ " has been linked to your Rudder!" ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this line to
Completed -> ( completeClass , completeIcon , "Your account "++ ac.username ++ " will be linked to your Rudder server" )
PR updated with a new commit |
This PR is not mergeable to upper versions. |
… end fixup! Fixes #20478: metrics are still present in wizard, and wizard doesn't end Fixes #20478: metrics are still present in wizard, and wizard doesn't end
45251ba
to
4a700de
Compare
OK, merging this PR |
https://issues.rudder.io/issues/20478