Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #20478: metrics are still present in wizard, and wizard doesn't end #4072

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Fixes #20478: metrics are still present in wizard, and wizard doesn't end #4072

merged 1 commit into from
Jan 3, 2022

Conversation

ncharles
Copy link
Member

@ncharles
Copy link
Member Author

This PR removes the metrics totally
However, it suffers from a massive problem as the message "Your account aaaaaa has been linked to your Rudder!" at the end is wrong. File is not yet saved when we display it, and I'm wondering why there is such a message there before saving

@amousset amousset requested a review from ElaadF December 29, 2021 14:59
ElaadF
ElaadF reviewed Dec 29, 2021
View reviewed changes
webapp/sources/rudder/rudder-web/src/main/elm/onboarding/sources/View.elm Outdated
@@ -74,10 +74,10 @@ view model =
Account s ac ->
case s of
Completed -> ( completeClass , completeIcon , "Your account "++ ac.username ++ " has been linked to your Rudder!" )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this line to

Completed -> ( completeClass , completeIcon , "Your account "++ ac.username ++ " will be linked to your Rudder server"  )

@ElaadF
Copy link
Member

ElaadF commented Dec 29, 2021

Metrics section is removed ✔️
image

@ncharles
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/4072
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/48880/console)

@ncharles
Fixes #20478: metrics are still present in wizard, and wizard doesn't…
4a700de 
… end

fixup! Fixes #20478: metrics are still present in wizard, and wizard doesn't end

Fixes #20478: metrics are still present in wizard, and wizard doesn't end
@ncharles ncharles force-pushed the bug_20478/metrics_are_still_present_in_wizard_and_wizard_doesn_t_end branch from 45251ba to 4a700de Compare January 3, 2022 10:15
@ncharles
Copy link
Member Author

ncharles commented Jan 3, 2022

OK, merging this PR

@ncharles ncharles merged commit 4a700de into Normation:branches/rudder/7.0 Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElaadF ElaadF ElaadF approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Trigger test
Projects
None yet
Milestone
No milestone
3 participants
@ncharles @ElaadF @Normation-Quality-Assistant