Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #20261: Add a warning in plugin page if a version mismatches rudder patch one #4085

Conversation

fanf
Copy link
Member

@fanf fanf commented Jan 5, 2022

https://issues.rudder.io/issues/20261

This change needs Normation/rudder-plugins#433 to work.

It brings back the old version format to Plugin version (in the code at least).

The main changes are:

  • it needs main-build.conf in the classpath at the same place as build.conf to have access to rudder ABI version (ie the version of rudder used to build that plugin jar)
  • simplify PluginVersion: in place of being some kind of poor copy of Version from utils, it's now just two Versions: one for the rudder ABI, the other for the plugin version
  • normalize each version on at least 3 dot separated numbers, adding "0" for missing parts
  • use the full plugin version (ie rudderABI-pluginOwnVersion) for the plugin object field version
  • compare between plugin.version.rudderAbi and RudderConfig.rudderFullVersion (ie current rudder) to check if a warning message should be displayed (see below):

image

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit c65e65f into Normation:branches/rudder/7.0 Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants