Fixes #20261: Add a warning in plugin page if a version mismatches rudder patch one #4085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/20261
This change needs Normation/rudder-plugins#433 to work.
It brings back the old version format to Plugin version (in the code at least).
The main changes are:
main-build.conf
in the classpath at the same place asbuild.conf
to have access to rudder ABI version (ie the version of rudder used to build that plugin jar)PluginVersion
: in place of being some kind of poor copy ofVersion
from utils, it's now just twoVersion
s: one for the rudder ABI, the other for the plugin versionrudderABI-pluginOwnVersion
) for the plugin object fieldversion
plugin.version.rudderAbi
andRudderConfig.rudderFullVersion
(ie current rudder) to check if a warning message should be displayed (see below):