Fixes #4149: Restore cat. with same name and different parents #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger.error("Ignoring Active Technique Categor with ID '%s' because its name is '%s' already referenced by category with ID '%s'".format( | ||
| cat.id.value, cat.name, id.value | ||
| } else categoryNamesByParent.get(cat.name) match { //name is mandatory | ||
| case Some(list) if list.contains(parent.id) => |
There was a problem hiding this comment.
isn't it a bit overzealous ?
If I have
|_ cat A
|__group1
|__catB
|___group1
group1 in cat A will fail because its parent are in those of catB
or am I not understanding something ?
|
looks good ! |
ncharles
added a commit
that referenced
this pull request
Jan 14, 2014
…ve_with_subcat_having_same_name Fixes #4149: Restore cat. with same name and different parents
fanf
deleted the
bug_4149/error_when_restoring_archive_with_subcat_having_same_name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.