Fixes #19720: when clicking on "show docs" on a generic method in the middle part of technique editor, it doesn't unfold the right part #4142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElaadF
force-pushed
the
bug_19720/when_clicking_on_show_docs_on_a_generic_method_in_the_middle_part_of_technique_editor_it_doesn_t_unfold_the_right_part
branch
from
4b3e799
to
796fb3f
Compare
|
Commit modified |
ElaadF
added
the
WIP
ElaadF
force-pushed
the
bug_19720/when_clicking_on_show_docs_on_a_generic_method_in_the_middle_part_of_technique_editor_it_doesn_t_unfold_the_right_part
branch
from
796fb3f
to
09fb55f
Compare
|
Commit modified |
ElaadF
force-pushed
the
bug_19720/when_clicking_on_show_docs_on_a_generic_method_in_the_middle_part_of_technique_editor_it_doesn_t_unfold_the_right_part
branch
from
09fb55f
to
c37e212
Compare
|
Commit modified |
ElaadF
removed
the
WIP
ElaadF
force-pushed
the
bug_19720/when_clicking_on_show_docs_on_a_generic_method_in_the_middle_part_of_technique_editor_it_doesn_t_unfold_the_right_part
branch
from
c37e212
to
d6e0209
Compare
|
Commit modified |
RaphaelGauthier
approved these changes
Feb 1, 2022
VinceMacBuche
approved these changes
Feb 2, 2022
|
This needs to be rebased |
VinceMacBuche
approved these changes
Feb 9, 2022
…he middle part of technique editor, it doesn't unfold the right part
ElaadF
force-pushed
the
bug_19720/when_clicking_on_show_docs_on_a_generic_method_in_the_middle_part_of_technique_editor_it_doesn_t_unfold_the_right_part
branch
from
d6e0209
to
59dec3d
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/19720
When the panel of method is closed and we click on "Show doc" it seems that the auto scroll doesn't go to the right location (see gif at the end) but we can double click (to close the doc and reopen) to trigger the scroll in the right location.