Fixes #20747: Use a unique id to identify reports #4167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Feb 10, 2022
|
|
||
| def jsonComponentExpectedReport(c : ExpectedValue): JValue = { | ||
| c match { | ||
| case v : ExpectedValueId => |
There was a problem hiding this comment.
we will need to still be able to deserialize old data structure to be able to have compliance for old explect reports
amousset
reviewed
Feb 15, 2022
| @@ -583,7 +583,7 @@ class ClassicTechniqueWriter(basePath : String, parameterTypeService: ParameterT | |||
| def reportingContext(methodCall: MethodCall, classParameterValue: String ) = { | |||
| val component = escapeCFEngineString(methodCall.component) | |||
| val value = escapeCFEngineString(classParameterValue) | |||
| s"""_method_reporting_context("${component}", "${value}")""" | |||
| s"""_method_reporting_context("${component}", "${value}","${methodCall.id}")""" | |||
There was a problem hiding this comment.
we need to duplicate the method to avoid breaking stuff during upgrade
There was a problem hiding this comment.
and we need the matching PR in ncf before merging this one
There was a problem hiding this comment.
Yes that will be a duplicated method. I need to validate the POC first.
VinceMacBuche
added
the
WIP
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
amousset
reviewed
Feb 17, 2022
webapp/sources/rudder/rudder-core/src/main/scala/com/normation/rudder/ncf/TechniqueWriter.scala
Outdated
Show resolved
Hide resolved
|
PR updated with a new commit |
fanf
added
Ready for merge
and removed
WIP
|
OK, squash merging this PR |
fanf
force-pushed
the
arch_20747/use_a_unique_id_to_identify_reports
branch
from
2ec67a8
to
15ad142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/20747