-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #20747: Use a unique id to identify reports #4167
Fixes #20747: Use a unique id to identify reports #4167
Conversation
|
||
def jsonComponentExpectedReport(c : ExpectedValue): JValue = { | ||
c match { | ||
case v : ExpectedValueId => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will need to still be able to deserialize old data structure to be able to have compliance for old explect reports
@@ -583,7 +583,7 @@ class ClassicTechniqueWriter(basePath : String, parameterTypeService: ParameterT | |||
def reportingContext(methodCall: MethodCall, classParameterValue: String ) = { | |||
val component = escapeCFEngineString(methodCall.component) | |||
val value = escapeCFEngineString(classParameterValue) | |||
s"""_method_reporting_context("${component}", "${value}")""" | |||
s"""_method_reporting_context("${component}", "${value}","${methodCall.id}")""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to duplicate the method to avoid breaking stuff during upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and we need the matching PR in ncf before merging this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that will be a duplicated method. I need to validate the POC first.
PR updated with a new commit |
1 similar comment
PR updated with a new commit |
webapp/sources/rudder/rudder-core/src/main/scala/com/normation/rudder/ncf/TechniqueWriter.scala
Outdated
Show resolved
Hide resolved
PR updated with a new commit |
OK, squash merging this PR |
2ec67a8
to
15ad142
Compare
https://issues.rudder.io/issues/20747