Fixes #20851: Regroup report with their values, not with the expanded value #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_20851/regroup_report_with_their_values_not_with_the_expanded_value
branch
from
5c99638
to
b4c8db7
Compare
|
Tests are not passing |
ncharles
reviewed
Mar 3, 2022
| @@ -342,6 +342,7 @@ final case class BlockStatusReport ( | |||
| } | |||
| final case class ValueStatusReport ( | |||
| componentName : String | |||
| , unexpanded : String | |||
There was a problem hiding this comment.
i'd rather have unexpandedComponentName, otherwise we may confuse it with the unexpandedValue
There was a problem hiding this comment.
I'll go with "ExpectedComponentName" with is more clear to me the unexpanded. Same for values
ncharles
reviewed
Mar 3, 2022
| @@ -439,14 +440,14 @@ object ComponentValueStatusReport extends Loggable { | |||
| * them by component *unexpanded* value | |||
| */ | |||
| def merge(values: Iterable[ComponentValueStatusReport]): List[ ComponentValueStatusReport] = { | |||
| val pairs = values.groupBy(_.unexpandedComponentValue).map { case (unexpanded, values) => | |||
| val pairs = values.toList /*groupBy(_.unexpandedComponentValue).map { case (unexpanded, values) => | |||
There was a problem hiding this comment.
I did wanted to no merge them, but i changed my mind and now i want them merged by real value, then by expectedValue
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_20851/regroup_report_with_their_values_not_with_the_expanded_value
branch
from
b4c8db7
to
a67a6c1
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_20851/regroup_report_with_their_values_not_with_the_expanded_value
branch
from
a67a6c1
to
36dcb52
Compare
|
Tests should now be ok |
ncharles
approved these changes
Mar 3, 2022
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/20851