Fixes #20943: Rudder incorectly parse URL with a '+' in the path into spaces #4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
|
PR updated with a new commit |
| // https://stackoverflow.com/questions/1634271/url-encoding-the-space-character-or-20/29948396#29948396 | ||
| (req.path.partPath.map { e => | ||
| // change back spaces into "+" | ||
| ApiPathSegment.Segment(e.replaceAll(" ", "+")) |
There was a problem hiding this comment.
What if there is a space intended ? can we try both ?
There was a problem hiding this comment.
I think we never want spaces in api path. This is very uncomon and a source of problems.
(that's not for the query parameters, just the path)
VinceMacBuche
approved these changes
May 12, 2022
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
bug_20943/rudder_incorectly_parse_url_with_a_in_the_path_into_spaces
branch
from
fc9c368
to
0c794c1
Compare
fanf
deleted the
bug_20943/rudder_incorectly_parse_url_with_a_in_the_path_into_spaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/20943
When on API, correct back "+" that were changed inot " " by lift
Also correct tests that were not returning the correct node :/