Fixes #19920: root inventory is missing and need to be resent after install #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
May 19, 2022
.../rudder/rudder-core/src/main/scala/com/normation/rudder/inventory/InventoryFileWatcher.scala
Outdated
Show resolved
Hide resolved
.../rudder/rudder-core/src/main/scala/com/normation/rudder/inventory/InventoryFileWatcher.scala
Outdated
Show resolved
Hide resolved
fanf
force-pushed
the
arch_19920/root_inventory_is_missing_and_need_to_be_resent_after_install
branch
from
32ce6ff
to
9dc81bd
Compare
|
Rebasing to prepare for merge |
fanf
commented
May 19, 2022
| ("queueMaxSize" -> inventoryProcessor.maxQueueSize) | ||
| ~ ("queueSaturated" -> saturated) | ||
| ("queueMaxSize" -> Int.MaxValue) | ||
| ~ ("queueSaturated" -> false) |
There was a problem hiding this comment.
I kept that to not break the API, but it makes little sense.
I propose to:
- do that for up to version 13
- create a version 14 with info
{"incomingInventories": XXX}the number of inventories in incoming+accepted-nodes-updates
It can be done after merging this PR.
ncharles
approved these changes
May 27, 2022
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
traitto make more clear what are the public API in services and how the are used in other services (code on interfaces)inventory.parse.parallelization, default1because it seems that in general, there is little advantage of making it more appart stressing LDAPinventories.watcher.max.age.before.deletion, remove unmatched pairshttps://issues.rudder.io/issues/19920