Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #21048: Improve rudderc testing system #4289

Merged
merged 1 commit into from May 24, 2022
Merged

Fixes #21048: Improve rudderc testing system #4289

merged 1 commit into from May 24, 2022

Conversation

amousset
Copy link
Member

@amousset amousset requested a review from Fdall May 23, 2022 17:26
@amousset amousset added Trigger test WIP Use that label for a Work In Progress PR that must not be merged yet labels May 23, 2022
@amousset
Copy link
Member Author

don't merge for now

@amousset
Copy link
Member Author

PR updated with a new commit

Fdall
Fdall reviewed May 23, 2022
View reviewed changes
language/tests/cases/states/state_audit.rd
@@ -0,0 +1,7 @@
@format=0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the naming of this one.

Copy link
Member Author

@amousset amousset May 23, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can split the refactoring and the improvement of the tests

Fdall
Fdall reviewed May 23, 2022
View reviewed changes
language/tests/cases/variables/variabledef_struct.rd
@format=0
resource x() {
let varname = {
"key1": "value1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a nested struct test if supported

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@Fdall
Copy link
Contributor

Fdall commented May 23, 2022

👍 It is a hundred times more readable this way!

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented May 23, 2022 •
edited

I finished porting everything as cargo tests:

  • Simple CLI tests that were in the Makefile are now in tests/cli.rs
  • test_all_techniques has been replaced by tests/loops.rs (and removed)
    • tester.sh has been replaced by tests/loop.rs
  • All the compiler test cases have be moved to categorized files in tests/cases, and the compilation test code is fully generic.

@amousset
Copy link
Member Author

I still have random tests failures in techniques I'll investigate.

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset amousset added Trigger test and removed WIP Use that label for a Work In Progress PR that must not be merged yet Trigger test labels May 23, 2022
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant force-pushed the bug_21048/improve_rudderc_testing_system branch from ae3770d to 7d0a0f2 Compare May 24, 2022 15:38
@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 7d0a0f2 into Normation:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdall Fdall Fdall approved these changes

Assignees
No one assigned
Labels
Ready for merge Trigger test
Projects
None yet
Milestone
No milestone
3 participants
@amousset @Fdall @Normation-Quality-Assistant