Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #21224: Add generic method metadata parsing to rudderc #4310

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Fixes #21224: Add generic method metadata parsing to rudderc #4310

merged 1 commit into from
Jun 7, 2022

Conversation

amousset
Copy link
Member

@amousset amousset commented Jun 6, 2022

@amousset amousset requested a review from Fdall June 6, 2022 19:09
@amousset amousset added the WIP Use that label for a Work In Progress PR that must not be merged yet label Jun 6, 2022
@amousset
Copy link
Member Author

amousset commented Jun 6, 2022

Still missing more tests

@amousset
Copy link
Member Author

amousset commented Jun 6, 2022

PR updated with a new commit

1 similar comment
@amousset
Copy link
Member Author

amousset commented Jun 6, 2022

PR updated with a new commit

@amousset amousset removed the WIP Use that label for a Work In Progress PR that must not be merged yet label Jun 6, 2022
@Normation-Quality-Assistant
Copy link
Contributor

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant force-pushed the arch_21224/add_generic_method_metadata_parsing_to_rudderc branch from 405b722 to a6ded41 Compare June 7, 2022 08:23
@Normation-Quality-Assistant Normation-Quality-Assistant merged commit a6ded41 into Normation:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdall Fdall Fdall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@amousset @Normation-Quality-Assistant @Fdall