Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #21304: Some reponses are missing in technique api doc #4342

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Fixes #21304: Some reponses are missing in technique api doc #4342

merged 1 commit into from
Jun 22, 2022

Conversation

ElaadF
Copy link
Member

@ElaadF ElaadF commented Jun 21, 2022 •
edited
Loading

https://issues.rudder.io/issues/21304
x-code-samples is deprecated use x-codeSamples instead

  • correct URL
  • reponse JSON is displayed

@ElaadF ElaadF requested a review from amousset June 21, 2022 08:51
@ElaadF ElaadF added the WIP Use that label for a Work In Progress PR that must not be merged yet label Jun 21, 2022
@ElaadF ElaadF force-pushed the bug_21304/some_reponses_are_missing_in_technique_api_doc branch from 62188e3 to 73be84c Compare June 21, 2022 12:34
@ElaadF
Copy link
Member Author

ElaadF commented Jun 21, 2022

Commit modified

@ElaadF ElaadF removed the WIP Use that label for a Work In Progress PR that must not be merged yet label Jun 21, 2022
@fanf
Copy link
Member

fanf commented Jun 22, 2022

Very interesting PR :)

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/4342
-- Your faithful QA
Kant merge: "Morality is not the doctrine of how we may make ourselves happy, but how we may make ourselves worthy of happiness."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/56035/console)

@ElaadF
Copy link
Member Author

ElaadF commented Jun 22, 2022

OK, merging this PR

@ElaadF ElaadF merged commit d8c0acf into Normation:branches/rudder/7.0 Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

@amousset amousset Awaiting requested review from amousset

@VinceMacBuche VinceMacBuche Awaiting requested review from VinceMacBuche

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
3 participants
@ElaadF @fanf @Normation-Quality-Assistant