Fixes #21238: Rename "classic nodes" to "unix node" #4351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be validated by a thread in produit. The terminology and semantics should be agreed on and shared throughout the team. |
ElaadF
added
the
WIP
|
PR updated with a new commit |
ElaadF
commented
Jun 27, 2022
webapp/sources/rudder/rudder-core/src/main/scala/com/normation/rudder/ncf/TechniqueWriter.scala
Outdated
Show resolved
Hide resolved
|
PR updated with a new commit |
4 similar comments
|
PR updated with a new commit |
|
PR updated with a new commit |
|
PR updated with a new commit |
|
PR updated with a new commit |
ElaadF
removed
the
WIP
|
PR updated with a new commit |
2 similar comments
|
PR updated with a new commit |
|
PR updated with a new commit |
fanf
approved these changes
Jul 1, 2022
|
This PR is not mergeable to upper versions. |
fixup! Fixes #21238: Rename \"classic nodes\" to \"unix node\" Fixes #21238: Rename \"classic nodes\" to \"unix node\" fixup! fixup! Fixes #21238: Rename \"classic nodes\" to \"unix node\" Fixes #21238: Rename \"classic nodes\" to \"unix node\" fixup! fixup! fixup! Fixes #21238: Rename \"classic nodes\" to \"unix node\" Fixes #21238: Rename \"classic nodes\" to \"unix node\" fixup! fixup! fixup! fixup! Fixes #21238: Rename \"classic nodes\" to \"unix node\" Fixes #21238: Rename \"classic nodes\" to \"unix node\" fixup! fixup! fixup! fixup! fixup! Fixes #21238: Rename \"classic nodes\" to \"unix node\" Fixes #21238: Rename \"classic nodes\" to \"unix node\" fixup! fixup! fixup! fixup! fixup! fixup! Fixes #21238: Rename \"classic nodes\" to \"unix node\" Fixes #21238: Rename \"classic nodes\" to \"unix node\" fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #21238: Rename \"classic nodes\" to \"unix node\" Fixes #21238: Rename \"classic nodes\" to \"unix node\" fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #21238: Rename \"classic nodes\" to \"unix node\" Fixes #21238: Rename \"classic nodes\" to \"unix node\" fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #21238: Rename \"classic nodes\" to \"unix node\" Fixes #21238: Rename \"classic nodes\" to \"unix node\"
|
PR rebased |
ElaadF
force-pushed
the
enh_21238/rename_classic_nodes_to_unix_node
branch
from
bee2cc9
to
cf0fbfa
Compare
|
OK, merging this PR |
ncharles
reviewed
Aug 30, 2022
| override def toRulesPath = "/dsc" | ||
| override def inventoryAgentNames = Set("dsc") | ||
| override val inventorySoftwareName = "Rudder agent (DSC)" | ||
| override val inventorySoftwareName = "Rudder agent (Windows)" |
There was a problem hiding this comment.
this break detection of windows version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/21238
