Fixes #21175: Impossible to put a Rule in a subcategory #4355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElaadF
force-pushed
the
bug_21175/impossible_to_put_a_rule_in_a_subcategory
branch
from
f393067
to
c186fdf
Compare
|
Commit modified |
1 similar comment
|
Commit modified |
ElaadF
force-pushed
the
bug_21175/impossible_to_put_a_rule_in_a_subcategory
branch
from
c186fdf
to
cc047fc
Compare
|
Commit modified |
ElaadF
force-pushed
the
bug_21175/impossible_to_put_a_rule_in_a_subcategory
branch
from
cc047fc
to
3c8254c
Compare
fanf
reviewed
Jun 28, 2022
| ) | ||
| restTestSetUp.ruleApiService14.listCategoriesId(root) shouldEqual(listCatIds) | ||
| } | ||
|
|
There was a problem hiding this comment.
you should add a test that you only get cat4 and children if starting from cat4 (locality) and that you correctly get nothing if non existing cat and that you only get one cat starting from cat1
fanf
reviewed
Jun 28, 2022
ElaadF
force-pushed
the
bug_21175/impossible_to_put_a_rule_in_a_subcategory
branch
from
3c8254c
to
84fb42e
Compare
|
Commit modified |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/21175