Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21477: Port policy writting test to rudder 7.1 #4400

Conversation

fanf
Copy link
Member

@fanf fanf commented Jul 25, 2022

@fanf fanf requested a review from ncharles July 25, 2022 23:03
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have been a pain to write. Thank you.
I have 1 question on the variable definitions and one remark on the directives definition

@fanf
Copy link
Member Author

fanf commented Jul 26, 2022

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/4400
-- Your faithful QA
Kant merge: "To be is to do."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/57646/console)

@fanf
Copy link
Member Author

fanf commented Jul 27, 2022

OK, squash merging this PR

@fanf fanf force-pushed the arch_21477/port_policy_writting_test_to_rudder_7_1 branch from 2a4d7b5 to 33492ca Compare July 27, 2022 16:39
@fanf fanf merged commit 33492ca into Normation:branches/rudder/7.1 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants