Fixes #4476: Correct the XML pretty printer to always preserve spaces #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
added a commit
that referenced
this pull request
Feb 18, 2014
…figuration_repo_files_may_erase_newlines Fixes #4476: Correct the XML pretty printer to always preserve spaces
fanf
deleted the
bug_4476/XML_pretty_printing_of_configuration_repo_files_may_erase_newlines
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To correct the behavior of the XML pretty printer, I had to copy&paste the source code of the original and change the "doPreserve" method which is private in scala.xml.PrettyPrinter.
All the remaining is just calling the good class.