Fixes #4481: Rudder should not fail on absence of licence file for Windo... #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case e : SAXParseException => logger.error("Cannot parse license file"); throw new ParsingException("Unexpected issue (unvalid xml?) with the config file " ) | ||
| case e : java.net.MalformedURLException => logger.error("Cannot read license file {}" + licenseFile); throw new FileNotFoundException("License file not found : " + licenseFile ) | ||
| case e : java.io.FileNotFoundException => | ||
| logger.debug("License file {} not found, this may be a problem if using the Windows Plugin", licenseFile) |
There was a problem hiding this comment.
Could you please use s"..... ${licenseFile}...."
It's easier to refacter logger that way (nothing slf4j specific)
There was a problem hiding this comment.
ha, didn't realize 2.6 was using scala 2.10.
fixing it
…le for Windows plugin
fanf
added a commit
that referenced
this pull request
Feb 18, 2014
…se_file Fixes #4481: Rudder should not fail on absence of licence file for Windo...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ws plugin