Fixes #21665: When we receive a lot of inventories, inotify "OVERFLOW" is not handled #4457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
.../rudder/rudder-core/src/main/scala/com/normation/rudder/inventory/InventoryFileWatcher.scala
Outdated
Show resolved
Hide resolved
.../rudder/rudder-core/src/main/scala/com/normation/rudder/inventory/InventoryFileWatcher.scala
Outdated
Show resolved
Hide resolved
|
|
||
| // if the listing fails, just exit | ||
| children <- ZIO.foreach(directories)(d => IOResult.effect(FileUtils.listFilesAndDirs( | ||
| d.toJava, |
There was a problem hiding this comment.
children <- ZIO.foreach(directories)( d =>
IOResult.effect(
FileUtils.listFilesAndDirs(d.toJava, TrueFileFilter.TRUE, TrueFileFilter.TRUE ).asScala
)
)
would be easier to read (cannot make suggestion on multiple lines ...
There was a problem hiding this comment.
not perfect indentation though, quite complicated to write through github
There was a problem hiding this comment.
hum, it seems that intellij changed indentation when it should have not, what a mess
There was a problem hiding this comment.
that part didn't change, I only move it up
There was a problem hiding this comment.
Yes , i have seen that it was just moved, and reindent, and yes it clearly feels that it was not rewritten by you !!
|
PR updated with a new commit |
…W\" is not handled
fanf
force-pushed
the
ust_21665/when_we_receive_a_lot_of_inventories_inotify_overflow_is_not_handled
branch
from
0d6e6c8
to
46d075e
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/21665
the correction is to handle the
OVERFLOWevent kind and trigger the clean-up process on it. We wait a bit before doing that, because if we gotOVERFLOW, likely the server is very busy.That need a bit of refactoring for the clean-up process: now, one part knows all about cleaning, and the other is just the scheduling.
Also handle the exception case for inotify with an error log.