Fixes #21784: add a default value for syslog facility output for agent and server compontent #4486
Conversation
| @@ -8,7 +8,8 @@ | |||
| }, | |||
| "server": { | |||
| "cf_serverd_bind_address": "::" | |||
| } | |||
| }, | |||
| "syslog_facility": "LOG_LOCAL3" | |||
There was a problem hiding this comment.
| "syslog_facility": "LOG_LOCAL3" | |
| "agent_syslog_facility": "LOG_LOCAL3" |
There was a problem hiding this comment.
IIRC it is only a setting for the agent
There was a problem hiding this comment.
if it's for agent only, it should be "agent": { "syslog_facility" : "LOG_LOCAL3" }
If it's for both, it seems worthy to have a "log" category, it seems common enough to be useful. I'm not sure why but I would prefer to minimize number of top level props.
There was a problem hiding this comment.
it's for both cf-agent and cf-serverd
There was a problem hiding this comment.
so, for now we will put it in log, and we will try to split / make it more granular if we want/can in further releases:
{ ...
"log": { "syslog_facility" : "LOG_LOCAL3" }
...
}
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
…t and server compontent
fanf
force-pushed
the
ust_21784/add_a_default_value_for_syslog_facility_output_for_agent_and_server_compontent
branch
from
47585c5
to
f3196fd
Compare
https://issues.rudder.io/issues/21784