Fixes #21809: Dont redirect other tabs to login form when session cookie is replaced - add a notification #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
fanf
reviewed
Sep 27, 2022
| @@ -360,7 +360,7 @@ class Boot extends Loggable { | |||
| // Do nothing instead, as at allows to keep open tabs context until we get the new cookie | |||
| // This does not affect security as it is only a redirection anyway and did not change | |||
| // the session itself. | |||
| LiftRules.noCometSessionCmd.default.set(() => JsCmd.unitToJsCmd(())) | |||
| LiftRules.noCometSessionCmd.default.set(() => JsRaw(s"createErrorNotification('You have been signed out. Please reload the page to sign in again.')").cmd) | |||
There was a problem hiding this comment.
We might check in the future if we want to do the same thing for noAjaxSessionCmd
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
…kie is replaced - add a notification
amousset
force-pushed
the
bug_21809/dont_redirect_other_tabs_to_login_form_when_session_cookie_is_replaced_add_a_notification
branch
from
354b8c4
to
c404eba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/21809