Fixes #21821: Refactor without trait #4505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Sep 22, 2022
| @@ -165,7 +165,7 @@ class CampaignApi ( | |||
| case eb: EmptyBox => Unexpected((eb ?~! "error when accessing request body").messageChain).fail | |||
| case Full(bytes) => campaignSerializer.parse(new String(bytes, charset)) | |||
| } | |||
| withId = if (campaign.info.id.value.isEmpty) campaign.copyWithId(CampaignId(stringUuidGenerator.newUuid)) else campaign | |||
| withId = if (campaign.info.id.value.isEmpty) campaign.copy(info = campaign.info.copy(id = CampaignId(stringUuidGenerator.newUuid))) else campaign | |||
There was a problem hiding this comment.
you will want quicklens for that in a further update
|
PR rebased |
VinceMacBuche
force-pushed
the
bug_21821/refactor_without_trait
branch
from
74f08ba
to
d76243c
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_21821/refactor_without_trait
branch
2 times, most recently
from
5e104ed
to
c76a937
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_21821/refactor_without_trait
branch
from
c76a937
to
15797af
Compare
|
Things diverged too much, and the draft seems abandoned, so I'm closing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/21821