Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #21806: #4514

Merged
merged 1 commit into from Sep 30, 2022
Merged

Fixes #21806: #4514

merged 1 commit into from Sep 30, 2022

Conversation

amousset
Copy link
Member

@amousset amousset requested a review from fanf September 26, 2022 14:34
@amousset amousset added the WIP Use that label for a Work In Progress PR that must not be merged yet label Sep 26, 2022
@amousset
Copy link
Member Author

Work in progress

@amousset
Copy link
Member Author

PR updated with a new commit

1 similar comment
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

1 similar comment
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset amousset removed the WIP Use that label for a Work In Progress PR that must not be merged yet label Sep 27, 2022
fanf
fanf reviewed Sep 30, 2022
View reviewed changes
webapp/sources/rudder/rudder-web/src/main/scala/bootstrap/liftweb/Boot.scala Outdated

// Custom session expiration that ignores comet requests
val IdleSessionTimeout = (sessions: Map[String, SessionInfo], delete: SessionInfo => Unit) => {
for ((id, info) <- sessions) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foreach would be better

@amousset
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/4514
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/60455/console)

@amousset
Copy link
Member Author

OK, squash merging this PR

@amousset amousset merged commit d38f6fd into Normation:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
3 participants
@amousset @Normation-Quality-Assistant @fanf