Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22054: Generate a proper metadata.xml #4561

Merged
merged 1 commit into from Nov 14, 2022
Merged

Fixes #22054: Generate a proper metadata.xml #4561

merged 1 commit into from Nov 14, 2022

Conversation

amousset
Copy link
Member

@amousset amousset commented Nov 7, 2022

@amousset amousset requested a review from Fdall November 7, 2022 17:10
@amousset amousset marked this pull request as draft November 7, 2022 17:10
@amousset amousset added the WIP Use that label for a Work In Progress PR that must not be merged yet label Nov 7, 2022
@amousset
Copy link
Member Author

amousset commented Nov 7, 2022

PR updated with a new commit

15 similar comments
@amousset
Copy link
Member Author

amousset commented Nov 8, 2022

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Nov 9, 2022

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Nov 9, 2022

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Nov 9, 2022

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Nov 9, 2022

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Nov 9, 2022

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Nov 9, 2022

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Nov 9, 2022

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Nov 9, 2022

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Nov 9, 2022

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset amousset force-pushed the arch_22054/generate_a_proper_metadata_xml branch from d8d2ab7 to fa12579 Compare November 10, 2022 22:11
@amousset
Copy link
Member Author

PR updated with a new commit

1 similar comment
@amousset
Copy link
Member Author

PR updated with a new commit

Fdall
Fdall reviewed Nov 11, 2022
View reviewed changes
policies/rudderc/tests/cases/general/min.xml
</AGENT>
<AGENT type="dsc">
<BUNDLES>
<NAME>Min</NAME>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "Min" and not "min" here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because that's what we do on Windows if I read the Scala implementation right, no exact idea why

@amousset
Copy link
Member Author

PR updated with a new commit

3 similar comments
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset amousset marked this pull request as ready for review November 14, 2022 15:33
@amousset amousset removed the WIP Use that label for a Work In Progress PR that must not be merged yet label Nov 14, 2022
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

OK, squash merging this PR

@amousset amousset force-pushed the arch_22054/generate_a_proper_metadata_xml branch from 7fcf184 to 11b313c Compare November 14, 2022 16:14
@amousset amousset merged commit 11b313c into Normation:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdall Fdall Fdall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@amousset @Fdall