Fixes #22100: When reading methods, if generic_methods.json does not exists, rudder should generate it #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
approved these changes
Nov 18, 2022
…exists, rudder should generate it
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_22100/when_reading_methods_if_generic_methods_json_does_not_exists_rudder_should_generate_it
branch
from
ea0e09a
to
b28530d
Compare
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
ncharles
reviewed
Nov 24, 2022
| methods | ||
| } | ||
| } else { | ||
| updateMethodsMetadataFile *> readMethodsMetadataFile(cache) |
There was a problem hiding this comment.
updateTechniquesMetadataFile fails in 7.2 because /usr/share/ncf/ncf write_all_methods fails in 7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22100