Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22209: Dynamic group logs must not be conflated with scheduled job ones #4613

Merged
merged 1 commit into from Jan 2, 2023
Merged

Fixes #22209: Dynamic group logs must not be conflated with scheduled job ones #4613

merged 1 commit into from Jan 2, 2023

Conversation

fanf
Copy link
Member

@fanf fanf commented Dec 23, 2022

@fanf fanf requested a review from ncharles December 23, 2022 11:11
@fanf
Copy link
Member Author

fanf commented Dec 23, 2022

PR updated with a new commit

3 similar comments
@fanf
Copy link
Member Author

fanf commented Dec 23, 2022

PR updated with a new commit

@fanf
Copy link
Member Author

fanf commented Dec 23, 2022

PR updated with a new commit

@fanf
Copy link
Member Author

fanf commented Dec 23, 2022

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/4613
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/63365/console)

@fanf
Copy link
Member Author

fanf commented Jan 2, 2023

OK, squash merging this PR

@fanf fanf force-pushed the bug_22209/dynamic_group_logs_must_not_be_conflated_with_scheduled_job_ones branch from a261e6e to 30ceb81 Compare January 2, 2023 13:05
@fanf fanf force-pushed the bug_22209/dynamic_group_logs_must_not_be_conflated_with_scheduled_job_ones branch from 30ceb81 to 66d2009 Compare January 2, 2023 13:08
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/4613
-- Your faithful QA
Kant merge: "To be is to do."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/63537/console)

@fanf
Copy link
Member Author

fanf commented Jan 2, 2023

OK, merging this PR

@fanf fanf merged commit 66d2009 into Normation:branches/rudder/7.2 Jan 2, 2023
@fanf fanf deleted the bug_22209/dynamic_group_logs_must_not_be_conflated_with_scheduled_job_ones branch March 15, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche VinceMacBuche approved these changes

@ncharles ncharles Awaiting requested review from ncharles

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
3 participants
@fanf @Normation-Quality-Assistant @VinceMacBuche