Fixes #22072: Display compliance by directive #4626

ElaadF · 2023-01-10T10:35:04Z

https://issues.rudder.io/issues/22072

Compliance by directive Id
Compliance on each directive
Export CSV API + frontend

ElaadF · 2023-01-11T09:39:04Z

Commit modified

ElaadF · 2023-01-11T09:41:03Z

PR rebased

ElaadF · 2023-01-11T10:46:56Z

PR updated with a new commit

VinceMacBuche · 2023-01-13T14:21:00Z

webapp/sources/rudder/rudder-web/src/main/elm/directivecompliance/sources/FakeUtils.elm

@@ -0,0 +1,40 @@
+module FakeUtils exposing (..)


You should remove FakeUtils

ElaadF · 2023-01-16T08:55:08Z

PR updated with a new commit

ElaadF · 2023-01-16T09:30:33Z

PR updated with a new commit

ElaadF · 2023-01-25T14:15:53Z

PR updated with a new commit

ElaadF · 2023-01-25T14:16:14Z

PR updated with a new commit

ElaadF · 2023-01-25T16:26:59Z

PR updated with a new commit

ElaadF · 2023-01-25T16:49:09Z

PR updated with a new commit

ElaadF · 2023-01-25T16:51:23Z

PR updated with a new commit

ElaadF · 2023-01-25T17:00:32Z

PR updated with a new commit

ElaadF · 2023-01-25T17:09:39Z

PR rebased

ElaadF · 2023-01-25T17:10:34Z

PR rebased

ElaadF · 2023-01-25T22:54:58Z

PR updated with a new commit

ElaadF · 2023-01-25T23:01:52Z

PR rebased

ElaadF · 2023-01-31T10:48:35Z

PR updated with a new commit

ElaadF · 2023-01-31T10:49:11Z

PR rebased

VinceMacBuche · 2023-01-31T13:36:19Z

...ources/rudder/rudder-rest/src/main/scala/com/normation/rudder/rest/EndpointsDefinition.scala

+    val dataContainer  = Some("directivesCompliance")
+  }
+
+  final case object ExportDirectiveComplianceCSV extends ComplianceApi with OneParam with StartsAtVersion10 with SortIndex {


I would rather have the URL to be compliance/directives/id/csv

(in fact i would prefer compliance/directives/id?format=csv

Yes i would définitely prefer one endpoint and choose the format as a parameter

why does it starts at version 10 and not the latest version ?

VinceMacBuche · 2023-01-31T13:39:32Z

...sources/rudder/rudder-rest/src/main/scala/com/normation/rudder/rest/lift/ComplianceApi.scala

+
+        directive <- complianceService.getDirectiveCompliance(id, level)
+        t3         = System.currentTimeMillis
+        _          = TimingDebugLogger.trace(s"API Export compliance to CSV - getting query param in ${t2 - t1} ms")


Why do you put your traces at the end ? you shoud make them just below what they are doing

VinceMacBuche · 2023-01-31T13:40:14Z

...sources/rudder/rudder-rest/src/main/scala/com/normation/rudder/rest/lift/ComplianceApi.scala

+        t4           = System.currentTimeMillis
+        directives   = directiveIds.flatMap(complianceService.getDirectiveCompliance(_, level))
+        t5           = System.currentTimeMillis
+        _            = TimingDebugLogger.trace(s"API GetDirectives - getting query param in ${t2 - t1} ms")


same here and it misses some cases

VinceMacBuche · 2023-01-31T13:41:14Z

...sources/rudder/rudder-rest/src/main/scala/com/normation/rudder/rest/lift/ComplianceApi.scala

+              precision.getOrElse(CompliancePrecision.Level2)
+            )
+          ) // by default, all details are displayed
+          val t4 = System.currentTimeMillis


Strange that it compiles with two T4

VinceMacBuche · 2023-01-31T17:48:11Z

I'm merging but we should treat the feedbacks during beta 2

Normation-Quality-Assistant · 2023-01-31T17:48:28Z

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/4626
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/64521/console)

ElaadF · 2023-01-31T23:34:21Z

OK, squash merging this PR

Fixes #22072: Display compliance by directive Fixes #22072: Display compliance by directive fixup! fixup! Work in progress Fixes #22072: Display compliance by directive fixup! fixup! fixup! Work in progress Fixes #22072: Display compliance by directive fixup! fixup! fixup! fixup! Work in progress Fixes #22072: Display compliance by directive fixup! fixup! fixup! fixup! fixup! Work in progress Fixes #22072: Display compliance by directive fixup! fixup! fixup! fixup! fixup! fixup! Work in progress Fixes #22072: Display compliance by directive fixup! fixup! fixup! fixup! fixup! fixup! fixup! Work in progress Fixes #22072: Display compliance by directive fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Work in progress Fixes #22072: Display compliance by directive fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Work in progress Fixes #22072: Display compliance by directive fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Work in progress Fixes #22072: Display compliance by directive fixup! fixup! Work in progress Fixes #22072: Display compliance by directive fixup! fixup! Work in progress Fixes #22072: Display compliance by directive

ncharles · 2023-02-21T12:58:13Z

webapp/sources/rudder/rudder-web/src/main/elm/directivecompliance/sources/ApiCalls.elm

+      request
+        { method  = "GET"
+        , headers = []
+        , url     = getUrl model ["nodes"] []


i'm unsure as to why you need that. If it's really necessary, you could fetfh nly the minimal version of the node, or minimal+ exactly what you need

ElaadF requested a review from RaphaelGauthier January 10, 2023 10:35

ElaadF added the WIP Use that label for a Work In Progress PR that must not be merged yet label Jan 10, 2023

ElaadF force-pushed the bug_22072/display_compliance_by_directive branch from 3d32b54 to af82377 Compare January 11, 2023 09:39

ElaadF force-pushed the bug_22072/display_compliance_by_directive branch from af82377 to 61cedb0 Compare January 11, 2023 09:41

ElaadF requested a review from VinceMacBuche January 11, 2023 13:03

VinceMacBuche reviewed Jan 13, 2023

View reviewed changes

ElaadF removed the WIP Use that label for a Work In Progress PR that must not be merged yet label Jan 25, 2023

ElaadF changed the base branch from master to branches/rudder/7.3 January 25, 2023 16:50

ElaadF requested a review from VinceMacBuche January 25, 2023 17:08

ElaadF force-pushed the bug_22072/display_compliance_by_directive branch from e6ce45c to 0c690d9 Compare January 25, 2023 17:09

ElaadF force-pushed the bug_22072/display_compliance_by_directive branch from d99923f to c86a597 Compare January 25, 2023 23:01

ElaadF mentioned this pull request Jan 25, 2023

Fixes #22072: Display compliance by directive #4600

Closed

ElaadF force-pushed the bug_22072/display_compliance_by_directive branch from c86a597 to 5940526 Compare January 31, 2023 10:44

ElaadF force-pushed the bug_22072/display_compliance_by_directive branch from da8f145 to e4c151b Compare January 31, 2023 10:49

VinceMacBuche reviewed Jan 31, 2023

View reviewed changes

VinceMacBuche approved these changes Jan 31, 2023

View reviewed changes

Normation-Quality-Assistant added the qa: Can't merge label Jan 31, 2023

ElaadF force-pushed the bug_22072/display_compliance_by_directive branch from e4c151b to 7c9df37 Compare January 31, 2023 23:34

ElaadF merged commit 7c9df37 into Normation:branches/rudder/7.3 Jan 31, 2023

ncharles reviewed Feb 21, 2023

View reviewed changes

ElaadF mentioned this pull request Feb 28, 2023

Fixes #22338: Refactor some code and changes API url for compliance by directive #4674

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #22072: Display compliance by directive #4626

Fixes #22072: Display compliance by directive #4626

ElaadF commented Jan 10, 2023 •

edited

Loading

ElaadF commented Jan 11, 2023

ElaadF commented Jan 11, 2023

ElaadF commented Jan 11, 2023

VinceMacBuche Jan 13, 2023

ElaadF commented Jan 16, 2023

ElaadF commented Jan 16, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 31, 2023

ElaadF commented Jan 31, 2023

VinceMacBuche Jan 31, 2023

VinceMacBuche Jan 31, 2023

VinceMacBuche Jan 31, 2023

ncharles Feb 21, 2023

VinceMacBuche Jan 31, 2023

VinceMacBuche Jan 31, 2023

VinceMacBuche Jan 31, 2023

VinceMacBuche commented Jan 31, 2023

Normation-Quality-Assistant commented Jan 31, 2023

ElaadF commented Jan 31, 2023

ncharles Feb 21, 2023

Fixes #22072: Display compliance by directive #4626

Fixes #22072: Display compliance by directive #4626

Conversation

ElaadF commented Jan 10, 2023 • edited Loading

ElaadF commented Jan 11, 2023

ElaadF commented Jan 11, 2023

ElaadF commented Jan 11, 2023

Choose a reason for hiding this comment

ElaadF commented Jan 16, 2023

ElaadF commented Jan 16, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 25, 2023

ElaadF commented Jan 31, 2023

ElaadF commented Jan 31, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VinceMacBuche commented Jan 31, 2023

Normation-Quality-Assistant commented Jan 31, 2023

ElaadF commented Jan 31, 2023

Choose a reason for hiding this comment

ElaadF commented Jan 10, 2023 •

edited

Loading