Fixes #22378: Generate policies for campaigns before it starts officially, delete them after it stops (1 hour delay each) #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Feb 16, 2023
| @@ -174,14 +174,15 @@ class MainCampaignService(repo: CampaignEventRepository, campaignRepo: CampaignR | |||
| event.copy(state = Skipped(s"Event was cancelled because campaign is archived. ${reasonMessage}")) | |||
| ) | |||
| case Enabled => | |||
| if (event.start.isAfter(now)) { | |||
| val effectiveStart = event.start.minusHours(1) | |||
There was a problem hiding this comment.
can you make these two time parameter of the MainCampaignService class so that it remains testable / configurable ?
fanf
reviewed
Feb 16, 2023
| if (event.start.isAfter(now)) { | ||
| val effectiveStart = event.start.minusHours(1) | ||
| val effectiveEnd = event.end.plusHours(1) | ||
| if (effectiveStart.isAfter(now)) { | ||
| for { | ||
| // Campaign should be planned, not running | ||
| _ <- | ||
| CampaignLogger.warn( | ||
| s"Campaign event ${event.id.value} was considered Running but we are before it start date, setting state to Schedule and wait for event to start, on ${DateFormaterService |
fanf
reviewed
Feb 16, 2023
| for { | ||
| // Campaign should be planned, not running | ||
| _ <- | ||
| CampaignLogger.warn( | ||
| s"Campaign event ${event.id.value} was considered Running but we are before it start date, setting state to Schedule and wait for event to start, on ${DateFormaterService | ||
| .serialize(event.start)}" | ||
| .serialize(effectiveStart)}, one hour before official start date, to ensure policies are correctly dispatched, nothing will be applied on the node" |
There was a problem hiding this comment.
comment will have to be adapted to the param to, something like:
s"Campaign event ${event.id.value} was considered Running but we are before its start date, setting state to
Schedule and wait for event to start, on ${DateFormaterService.serialize(effectiveStart)}, (starting befor official
start date (${event.start}), to ensure policies are correctly dispatched, nothing will be applied on the node)"
fanf
reviewed
Feb 16, 2023
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_22378/generate_policies_for_campaigns_before_it_starts_officially_delete_them_after_it_stops_1_hour_delay_each
branch
from
02e2945
to
fc8fc70
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_22378/generate_policies_for_campaigns_before_it_starts_officially_delete_them_after_it_stops_1_hour_delay_each
branch
from
fc8fc70
to
f577b99
Compare
…ally, delete them after it stops (1 hour delay each)
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_22378/generate_policies_for_campaigns_before_it_starts_officially_delete_them_after_it_stops_1_hour_delay_each
branch
from
f577b99
to
1e7f91b
Compare
fanf
approved these changes
Feb 16, 2023
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22378