Fixes #21731: Rule is in mixed mode even though she has only one directive in audit #4678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_21731/rule_is_in_mixed_mode_even_though_she_has_only_one_directive_in_audit
branch
from
6cd32c1
to
35fa4fc
Compare
|
Added a test case, else LGTM |
VinceMacBuche
force-pushed
the
bug_21731/rule_is_in_mixed_mode_even_though_she_has_only_one_directive_in_audit
branch
from
a3f8aa6
to
3770ea4
Compare
fanf
approved these changes
Mar 16, 2023
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_21731/rule_is_in_mixed_mode_even_though_she_has_only_one_directive_in_audit
branch
from
3770ea4
to
9f6fb25
Compare
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/21731