Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22427: Rewrite the angular app "Policy mode" in Elm #4680

Merged
merged 2 commits into from
May 11, 2023
Merged

Fixes #22427: Rewrite the angular app "Policy mode" in Elm #4680

merged 2 commits into from
May 11, 2023

Conversation

RaphaelGauthier
Copy link
Member

@RaphaelGauthier RaphaelGauthier added the WIP Use that label for a Work In Progress PR that must not be merged yet label Mar 3, 2023
@RaphaelGauthier
Copy link
Member Author

PR updated with a new commit

@RaphaelGauthier RaphaelGauthier removed the WIP Use that label for a Work In Progress PR that must not be merged yet label Mar 3, 2023
VinceMacBuche
VinceMacBuche reviewed Apr 9, 2023
View reviewed changes
Copy link
Member

@VinceMacBuche VinceMacBuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok to me, but, how did you manage to find out that you could remove 2,5k lines of css from rudder-menu.css ?

@RaphaelGauthier
Copy link
Member Author

PR rebased

@RaphaelGauthier RaphaelGauthier force-pushed the ust_22427/rewrite_the_angular_app_policy_mode_in_elm branch 2 times, most recently from 1c3d2d2 to 09acd56 Compare May 5, 2023 09:12
@RaphaelGauthier
Copy link
Member Author

Commit modified

@VinceMacBuche VinceMacBuche force-pushed the ust_22427/rewrite_the_angular_app_policy_mode_in_elm branch from 09acd56 to 28e8b32 Compare May 11, 2023 10:15
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit b701032 into Normation:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche VinceMacBuche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@RaphaelGauthier @Normation-Quality-Assistant @VinceMacBuche