Fixes #22617: #4751
Merged
Fixes #22617: #4751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
commented
Apr 7, 2023
| import zio.json.internal.Write | ||
|
|
||
| implicit val codecConfigValue: JsonCodec[ConfigValue] = JsonCodec( | ||
| new JsonEncoder[ConfigValue] { |
There was a problem hiding this comment.
strictly speaking, we don't need codec but we are going more and more toward zio-json, so it makes sense to have codec for that directly I think
|
I have tested, it seems to be ok |
ElaadF
approved these changes
Apr 13, 2023
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
1 similar comment
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22617
I tried several option with lift-json (deserializing
List[JValue], orList[NodePropWithJValue], or even aJValuebut the problem really seems to be somewhere in thelift-jsonparser for that very specific structure. So I just switched tozio-json