Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22659: Remove heartbeat configuration from the settings #4766

Merged
merged 1 commit into from Jul 11, 2023
Merged

Fixes #22659: Remove heartbeat configuration from the settings #4766

merged 1 commit into from Jul 11, 2023

Conversation

RaphaelGauthier
Copy link
Member

@RaphaelGauthier RaphaelGauthier commented Apr 20, 2023 •
edited

@RaphaelGauthier
Copy link
Member Author

There are still references to the Hearbeat configuration in the back-end code. I don't know if we should get rid of them too

@amousset
Copy link
Member

amousset commented Apr 20, 2023 •
edited

We should probably but in 8.0.

VinceMacBuche
VinceMacBuche previously approved these changes Jul 5, 2023
View reviewed changes
@VinceMacBuche
Copy link
Member

Did you try to save an heartbeat mode without value defined ?

@RaphaelGauthier
Copy link
Member Author

We can no longer change the heartbeat mode, saving works fine without a heartbeat value

@VinceMacBuche
Copy link
Member

Yes sorrty i meant "changes-only" but the api still needs a value, but you set it in fact (to 1) so it should be ok

@VinceMacBuche
Copy link
Member

(and i accepted the pr when i realised it but it does not merge :( )

@VinceMacBuche VinceMacBuche merged commit 875abb1 into Normation:branches/rudder/7.2 Jul 11, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche VinceMacBuche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@RaphaelGauthier @amousset @VinceMacBuche