Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #22870: Use 8080 port to talk with the webapp in hooks #4819

Conversation

amousset
Copy link
Member

@amousset amousset commented Jun 9, 2023

@amousset amousset requested a review from ncharles June 9, 2023 13:45
@amousset
Copy link
Member Author

amousset commented Jun 9, 2023

PR updated with a new commit

@@ -88,7 +88,7 @@ if [ -n "${RUDDER_NODE_IDS[0]}" ] && (( ${TO_UPDATE} > 0 )) ; then
if [ -n "${TEST}" ]; then
echo "${NODES}"
else
curl -X POST 'http://localhost/rudder/relay-api/remote-run/nodes' -d "asynchronous=true" -d "keep_output=false" -d @- <<CURL_DATA
curl -X POST 'http://localhost:3030/rudder/relay-api/remote-run/nodes' -d "asynchronous=true" -d "keep_output=false" -d @- <<CURL_DATA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, didn't see it coming

Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you SO much

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/4819
-- Your faithful QA
Kant merge: "Two things awe me most, the starry sky above me and the moral law within me."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/69403/console)

@amousset
Copy link
Member Author

amousset commented Jun 9, 2023

OK, squash merging this PR

@amousset amousset force-pushed the bug_22870/use_8080_port_to_talk_with_the_webapp_in_hooks branch from 04de616 to fdfc6dc Compare June 9, 2023 14:04
@amousset amousset merged commit fdfc6dc into Normation:branches/rudder/7.2 Jun 9, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants