Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22950: In rudder 7.3, we need to use npm for jsondiffpatch #4849

Merged
merged 1 commit into from Jun 26, 2023
Merged

Fixes #22950: In rudder 7.3, we need to use npm for jsondiffpatch #4849

merged 1 commit into from Jun 26, 2023

Conversation

fanf
Copy link
Member

@fanf fanf commented Jun 23, 2023 •
edited

https://issues.rudder.io/issues/22950
It's even nicer in 7.3 !
image

@fanf fanf requested a review from VinceMacBuche June 23, 2023 16:51
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/4849
-- Your faithful QA
Kant merge: "Happiness is not an ideal of reason, but of imagination."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/70006/console)

@fanf
Copy link
Member Author

fanf commented Jun 26, 2023

OK, merging this PR

1 similar comment
@fanf
Copy link
Member Author

fanf commented Jun 26, 2023

OK, merging this PR

@fanf fanf merged commit a6152c0 into Normation:branches/rudder/7.3 Jun 26, 2023
15 checks passed
@fanf fanf deleted the bug_22950/in_rudder_7_3_we_need_to_use_npm_for_jsondiffpatch branch March 15, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

@VinceMacBuche VinceMacBuche Awaiting requested review from VinceMacBuche

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@fanf @Normation-Quality-Assistant @amousset