Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #22967: Spurious test error about length of generated password #4854

Conversation

fanf
Copy link
Member

@fanf fanf commented Jun 28, 2023

@fanf fanf requested a review from amousset June 28, 2023 08:14
@amousset
Copy link
Member

missing formatting @fanf

@fanf
Copy link
Member Author

fanf commented Jun 28, 2023

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/4854
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/70211/console)

@fanf
Copy link
Member Author

fanf commented Jun 28, 2023

OK, squash merging this PR

@fanf fanf force-pushed the bug_22967/spurious_test_error_about_length_of_generated_password branch from dd9ad97 to db781af Compare June 28, 2023 10:44
@fanf
Copy link
Member Author

fanf commented Jun 28, 2023

OK, merging this PR

@fanf fanf merged commit db781af into Normation:branches/rudder/7.3 Jun 28, 2023
1 check was pending
@fanf fanf deleted the bug_22967/spurious_test_error_about_length_of_generated_password branch March 15, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants