Bug 4661/trigger promise gen on prop change (file retention, agent interval) #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#487 needs to be merged before (and put back in master) |
|
rebased on master! after #487 merge |
| @@ -497,6 +498,10 @@ class PropertiesManagement extends DispatchSnippet with Loggable { | |||
| S.error("cfagentScheduleMessage", e.messageChain) | |||
|
|
|||
| case Full(success) => | |||
|
|
|||
| // start a promise generation, Since we check if there is change to save, if we got there it mean that we need to redeploy | |||
| val modId = ModificationId(uuidGen.newUuid) | |||
There was a problem hiding this comment.
I'm wondering if i won't be better to have a method
def startNewPolicyGeneration() = asyncDeploymentAgent ! AutomaticStartDeployment(ModificationId(configService.stringUuidBuilder.newUuid), CurrentUser.getActor)
And just call that everywhere ? That's several times the exact same line removed.
There was a problem hiding this comment.
It can go only on 2.10, no pb to not have it in 2.9.
ncharles
added a commit
that referenced
this pull request
Mar 22, 2014
…en_on_prop_change Bug 4661/trigger promise gen on prop change (file retention, agent interval)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.rudder-project.org/redmine/issues/4661