Fixes #23041: Rewrite angular app "textForm" in JavaScript #4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
RaphaelGauthier
force-pushed
the
arch_23041/rewrite_angular_app_textform_in_javascript
branch
from
9e6b2e3
to
01fed83
Compare
VinceMacBuche
approved these changes
Jul 11, 2023
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 725091c
into
Normation:master
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23041
This is part of the plan to completely remove AngularJs from Rudder, for reasons of security and code maintenance.
No new features have been added, this is a rewrite of the AngularJs "techniqueVersion" application in pure Javascript, without using any front-end framework.
We have exceptionally chosen to rewrite this application in pure javascript, because the way the directives form is constructed makes using Elm complicated.
The js files related to the old application have been removed, and a new file 'directive-inputs.js' containing the new js code that run this feature has been added.